ritchie-cli icon indicating copy to clipboard operation
ritchie-cli copied to clipboard

Install script does not take system architecture into account

Open mortiet opened this issue 3 years ago • 2 comments

What happened: Installed ritchicli on armbian x64 and the install script didn't even notice that I'm on arm-based linux

What you expected to happen: Either the install script should inform the user that this architecture is not supported or you can provide binaries for different architectures

How to reproduce it (as minimally and precisely as possible): Try installing ritchicli on different linux architectures

Environment:

  • Ritchie version (use rit --version): 2.11.3
  • Operating System: Armbian x64
  • Network plugin / Tool and version (if this is a network-related / tool bug):
  • Others:

mortiet avatar May 15 '22 15:05 mortiet

Hi @mortiet! Thank you for opening this issue.

According to the documentation, Ritchie CLI currently has support for RPM, DEBIAN and ARCH LINUX.

The installation script (using curl -fsSL https://commons-repo.ritchiecli.io/install.sh | bash) doesn't check the linux version indeed, and Ritchie may not have support for Armbian x64.

Would you have any suggestion regarding how to create a package for this distribution using the linux binary?

GuillaumeFalourd avatar May 16 '22 11:05 GuillaumeFalourd

@GuillaumeFalourd You can cross-compile with golang for different architectures:

env GOOS=linux GOARCH=arm64 go build -o rit

And in the install.sh, this command shows the architecture $(uname -m)

  • "x86_64" --> Currently supported architecture
  • "aarch64" or "arm64" --> Arm64 architecture

mortiet avatar May 16 '22 12:05 mortiet