CXXGraph icon indicating copy to clipboard operation
CXXGraph copied to clipboard

Add macos ci/cd on cmake, benchmark and benchmark_pr

Open badumbatish opened this issue 1 year ago • 7 comments

Recommend by Zig in #433

Would love a review as well @ZigRazor

badumbatish avatar May 13 '24 07:05 badumbatish

Maybe we can add also windows in the matrix, and remove the Windows Cmake file for CI/CD

ZigRazor avatar May 13 '24 07:05 ZigRazor

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.88%. Comparing base (1b31e63) to head (7af9f44). Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   97.58%   97.88%   +0.29%     
==========================================
  Files          87       87              
  Lines        9492    10057     +565     
  Branches        0      666     +666     
==========================================
+ Hits         9263     9844     +581     
+ Misses        229      213      -16     
Flag Coverage Δ
unittests 97.88% <ø> (+0.29%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 13 '24 07:05 codecov[bot]

Maybe we can add also windows in the matrix, and remove the Windows Cmake file for CI/CD

idk how the -Dgtest_disable_pthreads=ON option in windows_cmake will affect things when going on mac and ubuntu but i can push the changes if you want

badumbatish avatar May 13 '24 07:05 badumbatish

we can try, then if don't work, we can review it

ZigRazor avatar May 13 '24 07:05 ZigRazor

ok should be fixed now

badumbatish avatar May 13 '24 08:05 badumbatish

We are waiting #427 to merge the PR

ZigRazor avatar May 13 '24 13:05 ZigRazor

Sounds good :)

badumbatish avatar May 13 '24 17:05 badumbatish