node-id3 icon indicating copy to clipboard operation
node-id3 copied to clipboard

Work in progress: Improve filestream

Open pbricout opened this issue 2 years ago • 0 comments

New implementation makes completely isomorphic the read/write sync and async implementation, the only difference in the async implementation are the file calls and the await. The new implementation handles multiple ID3 tags.

Still to do:

  • [x] Improve write implementation
  • [x] Make buffer size an option for write, write test to cover different code path for writeId3TagToFileSync/Async
  • [x] Improve read implementation
  • [ ] Refactor common parts of the steam process class
  • [ ] Make buffer size an option for read, write test to cover different code path for read
  • [ ] Support update
  • [ ] Add padding support
  • [x] Fix temp file generation, actually Date.now() may generate several times the same file especially when tests are ran in parallel and even more if the precision is reduced
  • [ ] Something is broken with Node 10.x I must use a feature not available in node 10.x

pbricout avatar May 07 '23 23:05 pbricout