Kamil Monicz comments

Results 346 comments of


                                            Kamil Monicz

Using Iterable with @retry leads to silent data corruption

I suggest replacing such cases with `Collection`

Database connections are never closed

I could prepare a PR dropping the singleton caching and moving all caching logic to the psycopg_pool (as it should imo).

Database connections are never closed

I'm confused about the purpose of using ConnectionPool and having the db_max_idle setting if they're not meant to be used. If users are expected to initialize PgstacDB via a context...

Typing improvements and loosened dependencies

"most of the requested changes were done" I don't think calling it "most" is correct here. This PR also aimed to resolve typing issues with the project (see the changed...

Invalid minified output when minifying Jinja template (brace_template_syntax)

It appears that the parser doesn't recognize template syntax in attribute part. This is likely the same issue as https://github.com/wilsonzlin/minify-html/issues/183.

Invalid minified output when minifying Jinja template (brace_template_syntax)

Seems like the comments are also broken when placed as attributes and keep_comments=True