YPImagePicker icon indicating copy to clipboard operation
YPImagePicker copied to clipboard

Preview clips non-square images

Open moltovivo opened this issue 5 years ago • 1 comments

Describe the bug After selecting multiple images from the library, they are displayed in the preview screen all as squares. Even if the isSquareByDefault is false. So photos which should be in portrait orientation are clipped at their top and bottom edges. The main problem with this is it can give the user the misleading impression that their photo has been cropped, before they upload it to the app.

To Reproduce Steps to reproduce the behavior:

  1. Enable multiple selection
  2. Select 2+ images in Library. (Portrait images correctly display as portrait in the Library -- e.g. screenshots). Tap Next.
  3. The Preview screen now shows all the images as squares, and portrait images are clipped at their top and bottom edges.

Expected behavior Would expect the Preview screen to show images in a similar way to how they are shown in the Library. E.g. Portrait images in full size and correct aspect ratio, rather than squares. It can give the user the misleading impression that their photo has been cropped.

Screenshots (see attached - original image , Library and Preview) 3 2 1

Environment (please complete the following information): iphone 8, ios14 - tested on others in Simulator with same behavior

Installation Type

  • Cocoapods

moltovivo avatar Dec 23 '20 02:12 moltovivo

I have the same problem.

NullYing avatar May 20 '24 04:05 NullYing

I'm closing old issues. Feel free to open new. Or better - make a PR :)

NikKovIos avatar Sep 21 '25 21:09 NikKovIos