react-flagpack icon indicating copy to clipboard operation
react-flagpack copied to clipboard
verified publisher icon Yummygum

Fix to support Storybook UI and React

Open erie149 opened this issue 4 years ago • 1 comments

erie149 avatar Jan 11 '22 19:01 erie149

Hi @erie149,

Thank you a lot for contributing to Flagpack!

I've checked your PR and it looks like it's having some issues regarding importing React. It looks like React shouldn't be a peerDependency.

When changing react to a regular dependency I'm also facing a bug where the SVG isn't loaded properly. I'm not completely sure why.

Google Chrome_18-01-2022_11-05-27 Google Chrome_18-01-2022_11-05-48

Are you able to reproduce this error? Please let me know.

donovanroubos avatar Jan 18 '22 10:01 donovanroubos