ZoneLoadingSystem icon indicating copy to clipboard operation
ZoneLoadingSystem copied to clipboard

Godot 4.03 for 2D

Open nextonphotos opened this issue 2 years ago • 9 comments

Hi! I use your system in my Godot 3 project and am looking to transition over to Godot 4.

First off, the warning_ignore lines now cause an error in the editor, but I just commented them out to get things running.

There seems to be a problem with the 2D demo in your project for me. There aren't any errors, however, only the initial zone seems to load in. The mini-map is blank and if I move out of the starting area, everything is just empty. I'm using Godot 4.03.

The 3D demo looks like it works without any problem.

Any ideas what the issue may be?

Thanks!

nextonphotos avatar Jun 01 '23 03:06 nextonphotos

Hello!

I don't plan to port this system to Godot 4, simply because now there is now a native asynchronous loading of the resources, so it renders my whole system a bit useless.

Check ResourceLoader.load_threaded_request in the Godot 4 docs: https://docs.godotengine.org/en/stable/classes/class_resourceloader.html

Please tell me if you are able to use this instead. Joël

Yogoda avatar Jun 01 '23 19:06 Yogoda

Thanks for the response! I just started messing around with Godot 4 a couple days ago, so I'm still discovering the new additions.

If I'm understanding correctly, in order to basically get feature parity with your system, I'd need to implement the various zone areas and then use the load_threaded_request to load the zones when necessary, yes?

On Thu, Jun 1, 2023 at 2:04 PM Yogoda @.***> wrote:

Hello!

I don't plan to port this system to Godot 4, simply because now there is now a native asynchronous loading of the resources, so it renders my whole system a bit useless.

Check ResourceLoader.load_threaded_request in the Godot 4 docs: https://docs.godotengine.org/en/stable/classes/class_resourceloader.html

Please tell me if you are able to use this instead. Joël

— Reply to this email directly, view it on GitHub https://github.com/Yogoda/ZoneLoadingSystem/issues/17#issuecomment-1572624571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESORKRTP5SLKX5JEKSLGXDXJDRSJANCNFSM6AAAAAAYWJUWX4 . You are receiving this because you authored the thread.Message ID: @.***>

nextonphotos avatar Jun 01 '23 19:06 nextonphotos

Yes, exactly.

I originally did the system because multithreading is very hard to get right but with the new threaded loading the rest should be pretty easy to do by yourself.

Still, if it is too complicated I can try to update to Godot 4.

Please tell me ;)

Yogoda avatar Jun 01 '23 20:06 Yogoda

I'll mess around with it and see what I can do. Thanks for the offer. If I get stuck I may ask a few questions.

Thanks!

On Thu, Jun 1, 2023, 3:36 PM Yogoda @.***> wrote:

Yes, exactly.

I originally did the system because multithreading is very hard to get right but with the new threaded loading the rest should be pretty easy to do by yourself.

Still, if it is too complicated I can try to update to Godot 4.

Please tell me ;)

— Reply to this email directly, view it on GitHub https://github.com/Yogoda/ZoneLoadingSystem/issues/17#issuecomment-1572743438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESORKUV7XXE4SFAB3EZ4OTXJD4ONANCNFSM6AAAAAAYWJUWX4 . You are receiving this because you authored the thread.Message ID: @.***>

nextonphotos avatar Jun 01 '23 21:06 nextonphotos

Just hopping on this thread to say thanks for creating this system!

I can also confirm everything except 2D scene works fine on Godot 4.

It will be great if you can update this to Godot 4, pretty please. 🥺🙏 That will be very helpful for noobs like me.

Yes, exactly.

I originally did the system because multithreading is very hard to get right but with the new threaded loading the rest should be pretty easy to do by yourself.

Still, if it is too complicated I can try to update to Godot 4.

Please tell me ;)

realpixelbard avatar Jun 15 '23 19:06 realpixelbard

Hello :)

Since you asked nicely I am now obliged to comply hehe.

I will try to port it to Godot 4 when I find the time ;)

Yogoda avatar Jun 15 '23 19:06 Yogoda

If it helps, I can send you my changes that got it working in Godot 4. I want to utilize the Godot 4 features you mentioned, but my focus at the moment was just getting my old project up and running in the updated engine.

I may have made some other tweaks that weren't strictly needed to update it, but I don't remember what all I did to it.

On Thu, Jun 15, 2023, 2:32 PM Yogoda @.***> wrote:

Hello :)

Since you asked nicely I am now obliged to comply hehe.

I will try to port it to Godot 4 when I find the time ;)

— Reply to this email directly, view it on GitHub https://github.com/Yogoda/ZoneLoadingSystem/issues/17#issuecomment-1593612287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AESORKVRMIUQSWLHIKSXZJ3XLNPLPANCNFSM6AAAAAAYWJUWX4 . You are receiving this because you authored the thread.Message ID: @.***>

nextonphotos avatar Jun 15 '23 19:06 nextonphotos

Thank you :) I will ask you if I'm stuck.

Yogoda avatar Jun 15 '23 20:06 Yogoda

Hello, I fixed the 2D demo :)

Please use the latest Godot 4.1 and download the new version from Github.

The issue was really simple: in the zone trigger of the player, uncheck the collision mask 16 and check the layer 16 (zone_triggers). (physics changed a little bit in 4.0).

Have a nice day, Joël

Yogoda avatar Jun 26 '23 09:06 Yogoda