realxdata coding challenge 2020 | Alfredo Narvaez

[alfdocimo]

Hi there! 👋

In the following PR, you can find my changes according to the coding challenge.

• I have done small refactors as well
• Implemented new functionality
• usage of local storage to avoid duplicated calls
• added two new dependencies react-tooltip & mapbox-gl to better implemented the new feature to display the geolocaltion of the pictures

Would love to discuss further my approach and decision-making process.

Thanks!

Hi there! 👋

Update: There are a couple of things I'd have liked to improve, like:

• Since we're using axios, I'd have set up redux with an axios-middleware and delegate the common ON_SUCCESS and ON_FAILURE actions to this implementation. Thus, we can add new queries to the service and the middleware would take care of the success and failure and updating the store correspondingly.

• Unit tests. I know that it would give me a greater sense of confidence to refactor my code if I have robust tests. Unfortunately writing good tests take time. If you would like to check an example of integration testing using RTL, I have a couple of repos with examples on them. Sorry - not gonna be able to work on them as of now 😅

• Enhance the MapPopover to a more cohesive design with app itself