whip
whip copied to clipboard
Yoast
A WordPress package to nudge users to upgrade their software versions (starting with PHP)
Issue https://github.com/Yoast/whip/issues/40 correctly suggested to get rid of the global variable (globals are always bad and should be avoided at all cost). However, the proposed solution in turns a single...
The interface `Whip_Requirement` wants to be an abstract requirement that only knows about a `::component()`. However, in `Whip_RequirementsChecker::requirementIsFulfilled()`, the requirements `version()` is being checked, despite the interface not having such...
The classes have their textdomain for localization injected through the constructor. This will not work in all instances, as `gettext()` only works by checking for simple strings, it does not...
I'm not sure if this is where I would ask this question. I recently wrote my host with this email. "Hi, For security reasons and an increase in speed I...
In the `Whip_Host.php` file, there are a couple of calls to `apply_filters()` with variable filter names. I'm not familiar enough with the code to properly review these, but I do...
Technically by being 'removable' once the issue is resolved (upgraded PHP) this is fine per the plugin guidelines. That's not this. This is a thought about keeping the WP Dashboard...
If I understood correctly, WHIP should work when installed in several different versions by different plugins. However, the way this is currently implemented will not work. The constant `WHIP_VERSION` will...
The `Whip_RequirementsChecker::addRequirement()` method only adds requirements for a component if that component has not yet been added. This should first compare the version requirements when dealing with duplicate components, and...
Instead of preparing the message(s) inside of a class, it might be preferable to have the message be provided through a view (that can contain placeholders). This would produce cleaner...