javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Abstract the "Close X" button in a button component

Open afercia opened this issue 6 years ago • 0 comments

Explanation

We have a few different implementations of a "X" close button here and there. For example in the yoast component for the new Alert https://github.com/Yoast/javascript/pull/349, and then on MyYoast see StyledCloseButtonTopRight in the Alert component there.

Since we're in the process of standardizing all the components, I'd like to propose to abstract this button in a reusable button component under Buttons instead of creating a local styled component each time.

Technical decisions

Feedback?

afercia avatar Sep 09 '19 15:09 afercia