YimMenuV2 icon indicating copy to clipboard operation
YimMenuV2 copied to clipboard

[Bug]: The release doesn't include the Binary file YimMenuV2.dll.

Open tomnookptn opened this issue 7 months ago • 5 comments

Describe the bug

The release doesn't include the Binary file YimMenuV2.dll.

For you, end users, you can still download it here. Here's the output of the automated Nightly Build Or here, direct link Or here Or if you feel lucky/risky, you can try the latest dev build

Steps To Reproduce

  1. Go to Release
  2. There is no YimMenuV2.dll.

Expected Behavior

Recreate Release should work and publish .dll.

Logs and/or screenshots

The logs is from the Recreate Release github action that crashed. This is public and verifiable here.

Run softprops/action-gh-release@v2
  with:
    name: Nightly [3eff87f]
    tag_name: nightly
    body: **This release has been built by Github Actions**
  [Link to build](https://github.com/YimMenu/YimMenuV[2](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:2)/actions/runs/155618[3](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:3)3152)
  
  Build SHA256:
  ed[4](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:4)6e9ec2cf25ae1a405fd9d708d3cbbbf3cf260b7388027123ccf9a293e60a9  YimMenuV2.dll
  To verify the build SHA2[5](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:5)6 during the action, click the build link, go-to "Create Release", open the Echo build sha25[6](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:6) step and read the sha256.
  
  You can download the build artifacts, generate a SHA256 checksum and compare it with the below binary.
  Build artifacts ARE NOT automatically the same as release assets since release assets can be modified afterwards.
  
  These are nightly builds of YimMenuV2, they are provided for testing purposes only:
  - Test if your build environment produces a broken YimMenuV2.dll
  - Test if source code is out of date and no longer compatible with the current version of Grand Theft Auto V: Enhanced
  
  If you wish to use this menu as-is you are on your own, no warranty is provided.
  
  Full Commit Hash:
  3eff8[7](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:7)f60c07becf9ab4b60a9e057bba[8](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:8)2bce02a
  
    files: YimMenuV2.dll
    token: ***
👩‍🏭 Creating new GitHub release for tag nightly...
⬆️ Uploading YimMenuV2.dll...

  #  /home/runner/runners/2.325.0/externals/node20/bin/node[1[9](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:9)82]: v8::MaybeLocal<v8::Promise> node::fs::FileHandle::ClosePromise() at ../src/node_file.cc:457
  #  Assertion failed: !closed_

----- Native stack trace -----

 1: 0xcc7f77 node::Assert(node::AssertionInfo const&) [/home/runner/runners/2.325.0/externals/node20/bin/node]
 2: 0xcd24fa node::fs::FileHandle::ClosePromise() [/home/runner/runners/2.325.0/externals/node20/bin/node]
 3: 0xcd2666 node::fs::FileHandle::Close(v8::FunctionCallbackInfo<v8::Value> const&) [/home/runner/runners/2.325.0/externals/node20/bin/node]
 4: 0xf6c56f v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/home/runner/runners/2.325.0/externals/node20/bin/node]
 5: 0xf6cddd  [/home/runner/runners/2.325.0/externals/node20/bin/node]
 6: 0xf6d2a5 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/home/runner/runners/2.325.0/externals/node20/bin/node]
 7: 0x1977df6  [/home/runner/runners/2.325.0/externals/node20/bin/node]

----- JavaScript stack trace -----

1: close (node:internal/fs/promises:250:23)
2: upload (/home/runner/work/_actions/softprops/action-gh-release/v2/dist/index.js:[16](https://github.com/YimMenu/YimMenuV2/actions/runs/15561833152/job/43816073164#step:6:16):16275)

Store

Other (please mention in "Additional context")

Anticheat bypass mode

With FSL

Additional context

This issue is related to the GitHub Repo, not in-game issue.

Build

  • [x] I've confirmed the issue exists on the latest version of YimMenuV2

tomnookptn avatar Jun 10 '25 15:06 tomnookptn

There's an issue with the specific action being used to make a nightly release: https://github.com/softprops/action-gh-release/issues/627

Potential fix could be to downgrade softprops/action-gh-release to v2.2.2: softprops/[email protected]

Yimura avatar Jun 10 '25 19:06 Yimura

This has been fixed, but I'm going to keep this open to see if we can migrate to a more actively maintained action

maybegreat48 avatar Jun 10 '25 20:06 maybegreat48

~~v2.3.1 fixed it~~ (it did not), but if you want to look at alternates, you might want to look at https://github.com/ncipollo/release-action. Though it is not "actively maintained". It's more like it actively receives security patches from dependabot.

eXhumer avatar Jun 10 '25 21:06 eXhumer

An alternative could be to use gh release create / gh release upload cli instead.

eXhumer avatar Jun 10 '25 21:06 eXhumer

There's most likely no need to switch out dependencies because they're not actively maintained, as long as the Github API doesn't deprecate the endpoints the action uses it should be fine.

This particular action is still being maintained from a security standpoint so that's already better than most of the actions out there.

@maybegreat48, I'm assuming this can be closed now as the underlying issue no longer pops up. For now I'd keep the action version locked.

Yimura avatar Jun 18 '25 12:06 Yimura

@maybegreat48, I'm assuming this can be closed now as the underlying issue no longer pops up. For now I'd keep the action version locked.

Sure

maybegreat48 avatar Jun 18 '25 15:06 maybegreat48