Flutter_Installer icon indicating copy to clipboard operation
Flutter_Installer copied to clipboard

Icons alignment or responsive Size issue

Open yahu1031 opened this issue 5 years ago • 5 comments

Issue Reference Image

OS: ParrotOS(Linux Distro)

Issue in detail

when we maximise the screen, The check/tick icons and the indicator dot/circle in stepsView has been enlarged as we show in above picture. This may be due to the responsive sizes or Wrong Icon alignment.

Fix

In /lib/src/ui/widgets/step_widget.dart line 59

CircleAvatar(
  maxRadius: blockSize(context)*2.5,
  minRadius: blockSize(context)*2,
  backgroundColor: Theme.of(context).scaffoldBackgroundColor,
),

Adding maxRadius and minRadius and also adding Icon size

In /lib/src/ui/widgets/step_widget.dart line 26

return Icon(
  Icons.done,
  size: blockSize(context) * 2.75,
  // you can even keep same if you wish not to change
  // size: blockSize(context) * 3,
  color: Theme.of(context).accentColor,
);

will fix this issue.

yahu1031 avatar Nov 02 '20 09:11 yahu1031

I have restricted resizing, though not the best way. I have added a method that checks in the build method of each screen whether the window size changed or not and if changed it resizes to 1200x720.

this is the method, full code here: https://github.com/YazeedAlKhalaf/Flutter_Installer/blob/master/lib/src/app/services/window_size_service.dart

Future<void> initialize() async {
    PlatformWindow platformWindow = await _getPlatformWindow();

    if (platformWindow.screen != null) {
      if (platformWindow.screen.visibleFrame.width != width ||
          platformWindow.screen.visibleFrame.height != height) {
        _setWindowSize(platformWindow);
      }
    }
  }

YazeedAlKhalaf avatar Nov 03 '20 06:11 YazeedAlKhalaf

@YazeedAlKhalaf Yeah I got it; but the thing is, it can be viewed in full size in linux(1920x1080). I have made changes depending on linux distro. I may also need to work on windows too. If you have linux just give it a shot. 😉

yahu1031 avatar Nov 03 '20 07:11 yahu1031

@yahu1031 does this issue happen in this repo or on your fork?

YazeedAlKhalaf avatar Mar 03 '21 16:03 YazeedAlKhalaf

from here and my fork both

yahu1031 avatar Mar 03 '21 18:03 yahu1031

I have a function that runs that makes the window stay at a specific size. If you change it, the window will resize. Currently, I don't use native ways of doing so but I am planning on adding some native code to make the window nonresizable!

YazeedAlKhalaf avatar May 03 '21 16:05 YazeedAlKhalaf