Yashar Fakhari

Results 73 comments of Yashar Fakhari

I think I figured out what the problem is. I verified that what you have in your original post doesn't work, but the same change in hackathon-starter does work. I...

I took another look at this repo: - I am not sure if I can sign the CLA that is required for PRs in this repo, at this time. So...

In hackathon-starter, we actually moved off of express-validator, to just validator (https://www.npmjs.com/package/validator). The reason behind it was the compatibility issues with express-validator 6: > Express-validator v6 removed legacy middleware methods,...

Can you provide examples of some custom stats which you would like to see?

You are missing a bunch of stuff in ``` OAuth2Strategy( { authorizationURL: "https://auth.sandbox.ebay.com/oauth2/authorize?", tokenURL: "https://api.sandbox.ebay.com/identity/v1/oauth2/token", clientID: "client-id" }, ``` See https://github.com/sahat/hackathon-starter/blob/master/config/passport.js#L484 for a working example

Sure, I can try to help.

I added https://github.com/underscopeio/sinon-mongoose/pull/49/commits/1561fdd5f38e4267a93dad92a5da570416409aaf not realizing that it is going to make the review process to have to restart.

@andyesp, @aschenkel I noticed https://github.com/orgs/underscopeio/people isn't listing @gaguirre as part of the org. I thought he was maintaining this package. This package, sinon-mongoose seems to need some love. It currently...

I think I only have partial permissions. The following is what is always showing up: ![image](https://user-images.githubusercontent.com/6448697/71739909-99539400-2e0f-11ea-89f8-f3b1c4a764dd.png)

I managed to remove the dependency on sinon-mongoose in my projects this morning; you can probably remove my permissions to merge in this repo if there is one. Thank you.