MapRend icon indicating copy to clipboard operation
MapRend copied to clipboard

Program dependencies in utilities

Open jfbarras opened this issue 10 years ago • 0 comments

I would like to discuss removing Program dependencies from the different utilities, eg Block.

public int getLight() {
    if(Program.renderNight) {
        return blockLight;
    }
    else {
        return blockLight > skyLight ? blockLight : skyLight; 
    }
}

would become

public int getLight(boolean renderNight) {
    if (renderNight) {
        return blockLight;
    }
    else {
        return blockLight > skyLight ? blockLight : skyLight; 
    }
}

I do not know how to create a pull request that will touch on multiple files. In the case above, I would need to modify Program.renderRegion.

jfbarras avatar Mar 18 '15 14:03 jfbarras