yacreader icon indicating copy to clipboard operation
yacreader copied to clipboard

Show .epub files in YACReaderLibrary?

Open rafaelgonzalez opened this issue 5 years ago • 7 comments

Hi there.

Publishers often provide DRM-free comics in multiple formats like .cbz, .pdf, .epub, etc.

YACReader is perfectly capable of opening .epub files, yet YACReaderLibrary does not show .epub files at all on Mac OSX. I can't speak for the versions for other operating systems.

Any reason for this?

Some of my comics have the highest image quality in the .epub files only. I would hate to have to keep lower quality files.

I have searched both here and the forum and there is barely any mention of epub files.

Cheers!

rafaelgonzalez avatar Jun 10 '20 22:06 rafaelgonzalez

YACReader is perfectly capable of opening .epub files, yet YACReaderLibrary does not show .epub files at all on Mac OSX. I can't speak for the versions for other operating systems.

Except it isn't. We have no epub support. Some files may work because the publisher actually does not take full advantage of the file format, which makes it just a zip file with images, but any real epub won't work.

Any reason for this?

As written above, we have no support for epub so the library does not scan for these files.

selmf avatar Jun 11 '20 06:06 selmf

Fair enough, that explains why you would be adverse to providing proper EPUB support, as that would go beyond the scope of just comics.

A shame, I'll have to convert those EPUB files to another format then. Thanks.

rafaelgonzalez avatar Jun 11 '20 08:06 rafaelgonzalez

Sorry if I came around a little harsh. We actually are interested in having .epub support. The issue is that there is no simple drop-in library with a suitable Open Source license we can use, so it isn't trivial to add it. For pdf, we have a rendering library and the comic book format already provides us with images, so YACReader basically is a better image viewer. For epub, we would need to write our own renderer. This is doable as epub is built upon web technology and we can use other libraries as the building blocks, but it requires a fair amount of work. I'm sure we already have some discussion regarding that topic on our forum, but it probably wouldn't hurt to have a feature request here too, so feel free to open one ;)

selmf avatar Jun 11 '20 08:06 selmf

Sorry if I came around a little harsh.

Oh no worries, you didn't come through harsh at all! 🤗

The joys of conveying emotion and tone online. 😉

We actually are interested in having .epub support. The issue is that there is no simple drop-in library with a suitable Open Source license we can use, so it isn't trivial to add it. For pdf, we have a rendering library and the comic book format already provides us with images, so YACReader basically is a better image viewer.

For epub, we would need to write our own renderer. This is doable as epub is built upon web technology and we can use other libraries as the building blocks, but it requires a fair amount of work.

Thanks for the further explanation. This makes a ton of sense.

I'm sure we already have some discussion regarding that topic on our forum, but it probably wouldn't hurt to have a feature request here too, so feel free to open one ;)

I would like to re-iterate that regarding the forums, I could find almost no mention of EPUB at all, based on a simple search: https://yacreader.com/forum/search?query=epub&childforums=1. Not a critique, just so you're aware.

In any case, I'm definitely happy if you want to leave this issue opened; I closed it assuming there was no intent to support EPUB in the future. Great to know otherwise!

rafaelgonzalez avatar Jun 13 '20 06:06 rafaelgonzalez

Submitted #140, since it's a prerequisite for this issue (#137)

rafaelgonzalez avatar Jun 13 '20 06:06 rafaelgonzalez

What we actually could do is add a setting to optionally just treat .epub as a .cbz, with a warning that this will only work for some books and will horribly fail on others. @luisangelsm has mentioned his interest in adding a similar feature for PDF files as comic publishers often use that format as an image container without using its actual features too.

selmf avatar Jun 14 '20 09:06 selmf

Speaking for myself, I'd be totally happy with that sort of solution.

rafaelgonzalez avatar Jun 19 '20 01:06 rafaelgonzalez