embeddedsw icon indicating copy to clipboard operation
embeddedsw copied to clipboard

GetPriorityTriggerType missing IntrId to IntrNum transform

Open digitalnumeric opened this issue 1 year ago • 1 comments

In xinterrupt_wrap.c, the function XSetPriorityTriggerType() includes code to transform the IntrId passed in as an argument to a IntrNum which it then passes to the XScuGic_SetPriorityTriggerType() function.

The function XGetPriorityTriggerType() is missing this transform. It takes the IntrId passed in as an argument and passes it directly to XScuGic_GetPriorityTriggerType() which results in hitting an assertion.

This can be corrected by adding the transformation from IntrId to IntrNum into XGetPriorityTriggerType() as done in the attached patch file: 0001-updated-XGetPriorityTriggerType-with-IntrId-to-IntrN.patch

Reference to where this was reported on the forums earlier this year: Vitis Unified IDE Bug in xinterrupt_wrap.h|.c XGetPriorityTriggerType() hanging at assertion on IntrId

digitalnumeric avatar Aug 30 '24 20:08 digitalnumeric

Hi, Thanks. We will take a look at it and fix it as needed. Will use the patch.

regards

anirudha1977 avatar Sep 02 '24 03:09 anirudha1977

It looks like xinterrupt_wrap.c XGetPriorityTriggerType() has been fixed in Vitis 2024.2. I see the following comment in the code. " 9.2 ... 11/09/24 Update XGetPriorityTriggerType() with IntrId to IntrNum transformation."

When will the github repo be updated to reflect the state of the code matching the 2024.2 release?

digitalnumeric avatar Nov 22 '24 15:11 digitalnumeric

See previous comment.

digitalnumeric avatar Dec 07 '24 03:12 digitalnumeric