XRT icon indicating copy to clipboard operation
XRT copied to clipboard
verified publisher icon Xilinx

Add pyxrt bindings for xrt::module and additional pyxrt bo and kernel constructors

Open fifield opened this issue 7 months ago • 6 comments

Problem solved by the commit

  • xrt::module is missing in the xrt python bindings (pyxrt)
  • Some constructors provided by xrt::ext::bo and xrt::ext:kernel in the xrt c++ api are missing in pyxrt

How problem was solved, alternative solutions (if any) and why they were rejected

  • Add xrt::module class to pyxrt
  • Add additional constructors to pyxrt bo and kernel classes from xrt::ext::bo and xrt::ext:kernel

What has been tested and how, request additional testing if necessary

The functionality has been tested with programs compiled by mlir-aie, e.g. https://github.com/Xilinx/mlir-aie/pull/2408

fifield avatar Jun 19 '25 15:06 fifield

fifield - is not a collaborator Can XRT admins please validate PR

gbuildx avatar Jun 19 '25 15:06 gbuildx

Can one of the admins verify this patch?

gbuildx avatar Jun 19 '25 15:06 gbuildx

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 19 '25 15:06 github-actions[bot]

ok to test

maxzhen avatar Jun 19 '25 15:06 maxzhen

How do we move this forward?

fifield avatar Jun 26 '25 23:06 fifield

ok to test

sonals avatar Jun 27 '25 23:06 sonals

This partially overlaps with #9040. Have asked @shaurjai to review if all the features in this PR are covered in #9040.

sonals avatar Jun 30 '25 18:06 sonals

This partially overlaps with #9040. Have asked @shaurjai to review if all the features in this PR are covered in #9040.

It looks like the use cases from this PR are covered, Thanks!

fifield avatar Jun 30 '25 18:06 fifield