PYNQ icon indicating copy to clipboard operation
PYNQ copied to clipboard

Fixed module disappearing outside pr area

Open tignear opened this issue 2 years ago • 5 comments

Assume that the static area contains the following modules.

  • processor(DFX)
  • processor_enable
  • xyz

When I reconfigured the "processor", the "processor_enable" module disappeared. It should be correct that it doesn't disappear, so I'll fix it that way.

tignear avatar Feb 15 '24 21:02 tignear

Hi @tignear,

Thank you for your contribution. We will review this for the next release.

mariodruiz avatar Mar 27 '24 08:03 mariodruiz

Hi @tignear, would it be possible to get a .hwh file so that we can investigate this issue that this PR fixes before evaluating if we can merge it onto the next release branch.

Thanks so much.

STFleming avatar May 01 '24 16:05 STFleming

project.zip

ol = Overlay("toplevel.bit")
ol.pipeline_enable # => ok
ol.pipeline.download("image_processor_id_partial.bit")
ol.pipeline_enable
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Input In [13], in <cell line: 1>()
----> 1 ol.pipeline_enable

File /usr/local/share/pynq-venv/lib/python3.10/site-packages/pynq/overlay.py:363, in Overlay.__getattr__(self, key)
    358 """Overload of __getattr__ to return a driver for an IP or
    359 hierarchy. Throws an `RuntimeError` if the overlay is not loaded.
    360 
    361 """
    362 if self.is_loaded():
--> 363     return getattr(self._ip_map, key)
    364 else:
    365     raise RuntimeError("Overlay not currently loaded")

File /usr/local/share/pynq-venv/lib/python3.10/site-packages/pynq/overlay.py:931, in _IPMap.__getattr__(self, key)
    929     return mem
    930 else:
--> 931     raise AttributeError(
    932         "Could not find IP or hierarchy {} in overlay".format(key)
    933     )

AttributeError: Could not find IP or hierarchy pipeline_enable in overlay

tignear avatar May 23 '24 05:05 tignear

Hi @tignear,

Can you try to rename pipeline_enable to something that does not start with pipeline?

Which board are you using?

mariodruiz avatar May 23 '24 07:05 mariodruiz

Can you try to rename pipeline_enable to something that does not start with pipeline?

It will work if I do that.

Which board are you using?

https://digilent.com/reference/programmable-logic/pynq-z1/start

tignear avatar May 24 '24 23:05 tignear