PYNQ icon indicating copy to clipboard operation
PYNQ copied to clipboard

MMIO enhancements to support read and write using different datatype

Open mariodruiz opened this issue 3 years ago • 1 comments

Support different datatypes for MMIO read and write.

  • Merge write functionality in a single method
  • MMIO.read arguments word_order and length are deprecated
  • MMIO.write detects datatype automatically
  • MMIO.read returns the datatype based on the dtype keyword (**kwargs). Eg. mmio.read(offset,dtype=np.float), default is int

Fix #634

mariodruiz avatar Jun 17 '22 13:06 mariodruiz

Codecov Report

Merging #1367 (308396a) into image_v2.8 (0cdf6b9) will decrease coverage by 0.04%. The diff coverage is 95.00%.

@@              Coverage Diff               @@
##           image_v2.8    #1367      +/-   ##
==============================================
- Coverage       46.49%   46.45%   -0.05%     
==============================================
  Files              28       28              
  Lines            4955     4960       +5     
  Branches          971      973       +2     
==============================================
  Hits             2304     2304              
- Misses           2594     2599       +5     
  Partials           57       57              
Impacted Files Coverage Δ
pynq/overlay.py 33.63% <0.00%> (ø)
pynq/mmio.py 100.00% <100.00%> (ø)
pynq/pl_server/xrt_device.py 29.53% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cdf6b9...308396a. Read the comment docs.

codecov-commenter avatar Jun 17 '22 13:06 codecov-commenter

Maintaining MMIO API through next release - closing for now

schelleg avatar May 01 '24 16:05 schelleg