PYNQ icon indicating copy to clipboard operation
PYNQ copied to clipboard

Release the zocl call by calling `device.close()`

Open mariodruiz opened this issue 4 years ago • 2 comments

  • Release the zocl call by calling device.close()
  • keep pl_server alive
  • grab XRT handle in _xrt_download if the handle is empty

With these changes after a Overlay.free() the instance of zocl is released, and by not stopping the pl_server we can download another overlay from the same notebook.

mariodruiz avatar Feb 10 '22 13:02 mariodruiz

Codecov Report

Merging #1338 (d67700d) into image_v2.8 (b85f453) will decrease coverage by 0.02%. The diff coverage is 14.28%.

Impacted file tree graph

@@              Coverage Diff               @@
##           image_v2.8    #1338      +/-   ##
==============================================
- Coverage       46.47%   46.45%   -0.03%     
==============================================
  Files              28       28              
  Lines            4953     4958       +5     
  Branches          971      972       +1     
==============================================
+ Hits             2302     2303       +1     
- Misses           2594     2598       +4     
  Partials           57       57              
Impacted Files Coverage Δ
pynq/overlay.py 33.55% <0.00%> (-0.08%) :arrow_down:
pynq/pl_server/xrt_device.py 29.13% <16.66%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b85f453...d67700d. Read the comment docs.

codecov-commenter avatar Feb 10 '22 13:02 codecov-commenter

Converting to draft to do more checking after this https://github.com/Xilinx/Kria-PYNQ/commit/92da27656d00c2b8843986f30590c4c832b80411

mariodruiz avatar Feb 23 '22 08:02 mariodruiz