xero-ruby icon indicating copy to clipboard operation
xero-ruby copied to clipboard

Invalid ENUM value EEK for class #CurrencyCode

Open xxswingxx opened this issue 2 years ago • 4 comments

When attempting to retrieve a list of currencies with

xero_client.accounting_api.get_currencies(tenant_id)

we get RuntimeError (Invalid ENUM value EEK for class #CurrencyCode)

The Estonian Kroon seems to be missing in the list of currencies: https://github.com/XeroAPI/xero-ruby/blob/master/lib/xero-ruby/models/projects/currency_code.rb

xxswingxx avatar Mar 23 '23 13:03 xxswingxx

PETOSS-286

github-actions[bot] avatar Mar 23 '23 13:03 github-actions[bot]

Thanks for raising an issue, a ticket has been created to track your request

github-actions[bot] avatar Mar 23 '23 13:03 github-actions[bot]

EEK is also missing in https://github.com/XeroAPI/xero-ruby/blob/master/lib/xero-ruby/models/accounting/currency_code.rb

xxswingxx avatar Mar 27 '23 08:03 xxswingxx

Hi @xxswingxx thanks for raising this, and for your PR. I've updated the OpenAPI spec for this, as it applies to all our SDKs. From that we will build the Ruby SDK with the missing currency codes you picked up.

pumpkinball avatar Mar 27 '23 15:03 pumpkinball