xero-node icon indicating copy to clipboard operation
xero-node copied to clipboard

Unable to upload documents from Readable stream

Open csharpsi opened this issue 1 year ago • 4 comments

When I perform an export, the file is not attached to the invoice. I have a unit test that proves that the document stream passed into the updateInvoiceAttachmentByFileName function matches the byte array of the test file and that is passing, so I am confident that the issue is with the SDK.

Example effected invoices:

  • 22e3d6d4-3442-444b-b109-fa359bcacef6
  • 3c425103-1d67-4189-9b1f-3ef1baf286e1

The below examples were imported into Xero, the first using the latest version of the xero-node SDK and the second using version 4.17.0

Latest Version

Version 4.17.0

Additionally, I am seeing a console.log message JSON parse body failed which looks to be coming from the SDK here

image

If I can help any further please let me know

Originally posted by @csharpsi in https://github.com/XeroAPI/xero-node/issues/631#issuecomment-2163016589

csharpsi avatar Jun 26 '24 09:06 csharpsi

PETOSS-446

github-actions[bot] avatar Jun 26 '24 09:06 github-actions[bot]

Thanks for raising an issue, a ticket has been created to track your request

github-actions[bot] avatar Jun 26 '24 09:06 github-actions[bot]

we experince the same issue, when do you estimate to fix the issue?

elena-dev-thought avatar Jul 03 '24 11:07 elena-dev-thought

Same here

MiscellaneousStuff avatar Jul 04 '24 20:07 MiscellaneousStuff

Hey @csharpsi @elena-dev-thought @MiscellaneousStuff

The issue has been addressed in our latest xero-node v9.0.0.

Please try using the latest version and let us know if the issue still persists.

sangeet-joy-tw avatar Jul 16 '24 06:07 sangeet-joy-tw

Hi @sangeet-joy-tw Thanks for the update. Looks like it's working nicely with v9

csharpsi avatar Jul 17 '24 15:07 csharpsi