XboxDev
samples: Make winapi samples unmount drives before finishing execution
This PR fixes issue #381. While I had previously opened a PR for this (#382), it was getting bloated, so I am opening this new one after I improved upon all the suggestions in the other PR.
Building failed previously, tired me forgot to test before pushing haha.
Errors fixed and building of both samples tested to work fine.
I just applied all the suggested changes, ready to make more if needed
No, you didn't. And it's very hard to keep track of what you did or how you resolved things.
I suggest to leave a comment on each review comment, telling the reviewer what you did to resolve it. That way it's much easier to confirm if you understood the feedback + to spot potential logic errors in the new solution. This is especially important for beginners like you, but should also be expected of experienced coders.
This is also taking up a lot of reviewer time and too many iterations for such a small change.
Building failed previously, tired me forgot to test before pushing haha.
This also confirms why it's taking so much time: to little testing locally, and too little reflection / review on your own work. You should review your own changes to make sure you only send a finalized version to reviewers, otherwise you are wasting everyones time (yours included).
Because this PR discussion is getting hard to follow (too much review feedback), I'd even consider starting a new PR if this doesn't reach an acceptable state in the next iteration.
Changed what I could and tested. If anything more is left I'd also gladly move it to a new PR (even though I know that I should have got it right a looooong time ago and that opening even this 2nd PR is a bit absurd)
I believe this is ready for a review and hopefully it's (at least one of the) final iteration(s).
Removal of return was indeed stupid of me, added it back now and ready for a new round of reviews if needed
I believe I have solved the merge conflicts, so this might be in the clear.