Xfx.Controls icon indicating copy to clipboard operation
Xfx.Controls copied to clipboard

Increase spacing between XfxEntry and Floating Label

Open brux88 opened this issue 8 years ago • 13 comments

Feature Request:

its possible set margin (spacing) between label and entry, in ios is too small.

brux88 avatar Jan 15 '18 11:01 brux88

at this time it's not possible. we've got two options to solve this for you.

  1. would be to fork the repo and change the iOS platform to your liking
  2. would be to flesh out what it would look like to make it settable cross platform and submit a PR

in the meantime, I'm going to adjust the naming a little on this issue and leave it open. If other's pipe up and say that the spacing on iOS is too small, maybe we can just increase that spacing overall.

ChaseFlorell avatar Jan 21 '18 15:01 ChaseFlorell

does this also include the spacing between the entry and the error text below?

ChaseFlorell avatar Jan 21 '18 15:01 ChaseFlorell

no only include spacing between entry and label

brux88 avatar Jan 22 '18 08:01 brux88

Yes, spacing on iOS is too small. So, what is the solution to increase the spacing b/w xfxEntry and it's floating labels?

Nishita1121 avatar Jan 29 '18 05:01 Nishita1121

Yes spacing on iOS is too small. Please fix. #brux88 do you found any solution?

Itouqeer avatar Apr 06 '18 18:04 Itouqeer

@brux88 do you found any solution?

Itouqeer avatar Apr 06 '18 18:04 Itouqeer

I do take pull requests. https://github.com/XamFormsExtended/Xfx.Controls/blob/master/src/Xfx.Controls.iOS/Controls/FloatLabeledTextField.cs

ChaseFlorell avatar Apr 06 '18 18:04 ChaseFlorell

@ChaseFlorell thanks for your swift response. Dude i am a beginner can you please guide how i can solve this?

Itouqeer avatar Apr 06 '18 18:04 Itouqeer

The spacing is hard-coded (and will remain so). I looked at the spacing on Android, and agree that iOS needs an additional gap, The file I linked to above is where you will adjust the spacing.

ChaseFlorell avatar Apr 06 '18 18:04 ChaseFlorell

@ChaseFlorell dude i just installed the package uaing nuget how can i edit that?

Itouqeer avatar Apr 06 '18 18:04 Itouqeer

you'd have to fork this repository, make the adjustments, and submit a pull request. If you're not comfortable with that, you'll have to wait until I can tackle it, or someone else is willing to take it on.

ChaseFlorell avatar Apr 06 '18 18:04 ChaseFlorell

Ok @ChaseFlorell thanks for your time. Ok i can wait. Hope it can be solved soon.

Itouqeer avatar Apr 06 '18 18:04 Itouqeer

Hi Guys. This solution would really be a boost for this plugin. Thanks

technololy avatar Jun 07 '18 12:06 technololy