Sam Xie
Sam Xie
@open-telemetry/go-approvers PTAL
Overall, it looks good to me. I only have this question to address. https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6002#discussion_r1719158071
@psx95 Yes, I was expecting you to confirm this just in case we missed something. Closing it.
Hi @debuggerpk, thanks for raising this issue. I am not sure about the scenario that custom comments could solve. Could you please describe more about the new keys that CloudSQL...
@aereal Thanks for raising this issue! This is a good suggestion. I am considering creating an option to get attributes at the end of the operation for both traces and...
This is related to spec compliance. It looks like we need to adjust the retry mechanism a little bit to meet the requirement.
I found that the `context deadline exceeded` error is coming from other options, which prevents the `retry` mechanism from reaching the default [`MaxElapsedTime`](https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/internal/retry#Config) (1 minute). **The `retry` mechanism is actually...
> However, those env variables only work with otlpgrpc despite of generic names. OTEL_EXPORTER_OTLP_TIMEOUT should also work for OTLP HTTP exporter. Proof: - https://github.com/open-telemetry/opentelemetry-go/blob/12c7d7ef512656cd7373f0822136361863e984f8/exporters/otlp/otlptrace/otlptracehttp/internal/otlpconfig/options_test.go#L434 And, OTEL_BSP_EXPORT_TIMEOUT is an environment variable...
Could anyone take a look? Thanks! @emcfarlane @pkwarren
superseded by #196