BasicSR icon indicating copy to clipboard operation
BasicSR copied to clipboard
verified publisher icon XPixelGroup

call `deform_conv2d` from torchvision when possible

Open wwhio opened this issue 3 years ago • 3 comments

Make it easy when compiling environment is not suitable.

wwhio avatar Apr 20 '22 09:04 wwhio

This pull request introduces 1 alert when merging 548a79d470a4af4af7e9c9ed64704d887347fd9c into dd7d188b4adaf9b2b6db303e01b4de7c28d2d737 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Apr 20 '22 10:04 lgtm-com[bot]

thanks for your contribution.

This function has already been implemented in https://github.com/xinntao/BasicSR/blob/ab55f479f26ca28cd03426ef492f83fec4f4c68c/basicsr/archs/arch_util.py#L231-L236

You may check it. Thanks :-)

xinntao avatar Apr 26 '22 15:04 xinntao

Thank you for your reply.

I knew that. But my PR will work with all DCN related things instead of DCNv2Pack only. And I think this could be a solution to many DCN compilation issues.

wwhio avatar Apr 27 '22 02:04 wwhio

The general dcn from torchvision can be directly called by users, so I choose not to merge this pr. Thanks for your contribution: -)

xinntao avatar Sep 06 '22 15:09 xinntao