XoopsCore25 icon indicating copy to clipboard operation
XoopsCore25 copied to clipboard

Remove bt3 themes

Open GregMage opened this issue 4 years ago • 10 comments

Soon bt5 will be released and xoops continues to offer bt3 themes in xoops. I think we should keep bt4 themes only (maybe put xbootstrap in version 4). It becomes complicated to make templates for all these versions. My modules offer bt3 and bt4 but I would like to stop bt3 support to offer basic bt4. You can always put the bt3 themes in another repository if you want to keep them.

GregMage avatar Mar 14 '21 10:03 GregMage

Please help with B4 and B5 versions of xBootstrap, and then we could replace the current Bootstrap3 with the B4 version :

https://github.com/mambax7/xbootstrap4

https://github.com/mambax7/xbootstrap5

mambax7 avatar Mar 14 '21 10:03 mambax7

SAme type of discussion here : :-) https://github.com/XoopsModules25x/wggithub/issues/23#issuecomment-797262088

alain01 avatar Mar 14 '21 16:03 alain01

@mambax7 Have you tried the bt4 xswatch4 templates of the modules on xbootstrap4? Normally it should be up and running, right? As for the main theme (theme.tpl), it is obviously something else.

alain01 avatar Mar 14 '21 16:03 alain01

I think version 2.5.11 should no longer contain bootstrap 3.X themes. We shouldn't wait for version 2.5.12 to do this. People should start using a minimum boostrap version of 4.x

GregMage avatar Feb 18 '22 17:02 GregMage

I agree with you, and the goal is to have https://github.com/mambax7/xbootstrap5 ready for 2.5.11, and @Heyula is working on making updates for it and to the templates of the various modules. With @alain01 and you working on xSwatch4, we should be then ready to go for 2.5.11

mambax7 avatar Feb 18 '22 17:02 mambax7

Hmmm, that's a big job. And if a webmaster is already using the xswatch4 theme, with the xswatch5 theme, he might have weird things in his content, if he was using bootstrap 4 features. I can explain more if needed. So for me, keep xswatch4 for XOOPS 2.5.11 For xswatch5, when it's ready, we'll have to test it and we don't have any feedback yet. If you want to release 2.5.11 quickly, I think we won't be ready for a reliable and robust xswatch5.

alain01 avatar Feb 18 '22 18:02 alain01

@alain01, I was talking about xBootstrap5 theme: https://github.com/mambax7/xbootstrap5, that is using Bootstrap 5.x

This has nothing to do with the xSwatch4 theme that you're working on, and I didn't suggest that you should switch to Bootstrap 5.x, so just keep on working on the xSwatch4 and on testing it!

If we could have both included, i.e. xSwatch4 and xBootstrap5, then we have a good solution! :)

mambax7 avatar Feb 18 '22 18:02 mambax7

In any case, it is necessary to remove boostrap 3.x themes. For me, it is possible to quickly have a boostrap 5 theme!

We can for example keep xswatch4 which would be the official bootstrap 4 theme (it has been tested for a long time and it works) and make the xboostrap5 theme which is the official boostrap 5 theme.

For version 2.5.12 we will make xswatch5 theme and we will remove xswatch4 theme

GregMage avatar Feb 18 '22 19:02 GregMage

It sounds good

alain01 avatar Feb 18 '22 21:02 alain01

The Bootstrap 3 based xSwatch theme contains multiple fixes including a security fix. It should be made available for anyone that is using a theme derived from it.

geekwright avatar Feb 19 '22 04:02 geekwright