DRAM icon indicating copy to clipboard operation
DRAM copied to clipboard

DRAM-setup.py in v1.5.0 has invalid syntax

Open donovan-parks opened this issue 1 year ago • 1 comments

Hi. I am installing DRAM onto a fresh Ubuntu VM via mamba. Installation into a conda environment works without issue. However, setting up of the DRAM DBs with DRAM-setup.py is currently broken::

>DRAM-setup.py -h
  File "/home/dparks/miniforge3/envs/DRAM/bin/DRAM-setup.py", line 124
    set_db_locs_parser.add_argument('--camper_tar_gz_loc', default=None,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: invalid syntax. Perhaps you forgot a comma?

This does indeed appear to be due to invalid syntax on line 124 of DRAM-setup.py as shown below:

    set_db_locs_parser.add_argument('--viral_loc', default=None,
    set_db_locs_parser.add_argument('--camper_tar_gz_loc', default=None,
                                    help='The source for the CAMPER database files, this is a tar.gz file downloaded'
                                    ' from the release page https://github.com/WrightonLabCSU/CAMPER/releases')
                                    help='mmseqs2 database file from ref seq viral gene collection')
    set_db_locs_parser.add_argument('--peptidase_loc', default=None,
                                    help='mmseqs2 database file from MEROPS database')

Cheers, Donovan

donovan-parks avatar Sep 25 '24 17:09 donovan-parks

As devs have mentioned elsewhere, the best solution is to wait for DRAM v2.

This is probably the best way to fix, but not necessarily encouraged by devs: https://github.com/WrightonLabCSU/DRAM/issues/330

Edited to replace hack-ey solution with better one.

Gsmith535 avatar Dec 20 '24 20:12 Gsmith535