StompClientLib icon indicating copy to clipboard operation
StompClientLib copied to clipboard

Swift Package Manager Support

Open fred-bowker opened this issue 1 year ago • 7 comments

There is an issue ticket for this but it is closed https://github.com/WrathChaos/StompClientLib/issues/122 Can we add the Swift Package manager support I don't see any Packages.swift. If you're ok with adding this, I'm happy to put in a pull request for this.

Cheers for creating StompClientLib

fred-bowker avatar Jun 13 '24 17:06 fred-bowker

@fred-bowker great idea, looking for this!

teendream avatar Jul 25 '24 05:07 teendream

Hey @fred-bowker Thank you so much for the contribution. If you can create a PR for it, it would be awesome.

WrathChaos avatar Jul 25 '24 05:07 WrathChaos

Hi @fred-bowker @WrathChaos any updates?

teendream avatar Jul 30 '24 13:07 teendream

Hi @WrathChaos can you review https://github.com/WrathChaos/StompClientLib/pull/130 , please?

teendream avatar Jul 31 '24 09:07 teendream

Hi @teendream There are too many changes in your PR, please take a look at it

WrathChaos avatar Jul 31 '24 11:07 WrathChaos

@WrathChaos Hi, it looks like @teendream is looking into implementing the swift package manager support, if it is not done by the end of August, I'll do the change and put up a pull request, cheers Fred

fred-bowker avatar Jul 31 '24 17:07 fred-bowker

@fred-bowker yes I need spm implementation, I forked it and experimenting it. So I'm in the stage where I need add SocketRocket as dependency to the StompClient. But SocketRocket also does not have SPM implementation, so I'm wrapping it too. Problems with headers in objc. Would be great if somebody helps me with direction where I need to dig. Thanks beforehand.

fatal error: 'NSRunLoop+SRWebSocketPrivate.h' file not found
#import "NSRunLoop+SRWebSocketPrivate.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fatal error: 'NSURLRequest+SRWebSocketPrivate.h' file not found
#import "NSURLRequest+SRWebSocketPrivate.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 let package = Package(
    name: "SocketRocket",
    platforms: [.iOS(.v12)],
    products: [
        .library(
            name: "SocketRocket",
            targets: ["SocketRocket"]
        ),
    ],
    targets: [
        .target(
            name: "SocketRocket",
            path: "SocketRocket",
            publicHeadersPath: "include"
        ),
        .testTarget(
            name: "SocketRocketTests",
            dependencies: ["SocketRocket"]
        ),
    ],
    cLanguageStandard: .c11,
    cxxLanguageStandard: .cxx11
)

teendream avatar Aug 01 '24 04:08 teendream