react-dart icon indicating copy to clipboard operation
react-dart copied to clipboard

React 18.2.0

Open greglittlefield-wf opened this issue 2 years ago • 6 comments

Based on https://github.com/Workiva/react-dart/pull/339

greglittlefield-wf avatar Aug 10 '23 18:08 greglittlefield-wf

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

aviary3-wk avatar Aug 10 '23 18:08 aviary3-wk

@greglittlefield-wf We started getting react.js and react_dom.js must be loaded. errors because https://cdn-dev.wdesk.org/react-dart/5167194/react_with_react_dom_prod.js no longer exists -- it looks like we must have a 3 month expiry on cdn-dev assets?

I resolved the conflicts and pushed up a change. The tests fail but it successfully generated an asset. Hopefully this will fix our issue 🤞

edit This worked for us

regenvanwalbeek-wf avatar Feb 12 '24 15:02 regenvanwalbeek-wf

@regenvanwalbeek-wf Sorry about that! 😬

Hmm to help prevent this issue from happening again, would it be possible to load from a local packages/react/... path rather than the dev CDN?

greglittlefield-wf avatar Feb 12 '24 16:02 greglittlefield-wf

That's how I was leaning as well - Once I have some free time I will give that a shot (hopefully by tomorrow)

regenvanwalbeek-wf avatar Feb 12 '24 16:02 regenvanwalbeek-wf

@regenvanwalbeek-wf Sounds good, let me know if we can help with anything!

greglittlefield-wf avatar Feb 12 '24 16:02 greglittlefield-wf

(Forgot to mention, we ended up loading from local and it worked fine https://github.com/Workiva/esg_ui/pull/2765)

regenvanwalbeek-wf avatar Feb 19 '24 17:02 regenvanwalbeek-wf