json_schema icon indicating copy to clipboard operation
json_schema copied to clipboard

feat(package): support relative refs in resolvePath

Open joshriesenbach-wk opened this issue 2 years ago • 1 comments

Ultimate problem:

we don't resolvePath on relative refs (i.e. /items vs #/items)

How it was fixed:

Look for / in resolvePath to see if there is a relative path. If so append it to the current schema's path. If not, pass in the unchanged argument path.

Testing suggestions:

Two tests added for both relative and root paths.

Potential areas of regression:


FYA: @michaelcarter-wf

joshriesenbach-wk avatar Jun 05 '23 20:06 joshriesenbach-wk

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

aviary-wf avatar Jun 05 '23 20:06 aviary-wf

Closing because of inactivity. If this is still an issue, please reopen.

joecotton-wk avatar Jul 24 '24 20:07 joecotton-wk