canvas-kit icon indicating copy to clipboard operation
canvas-kit copied to clipboard

chore: Modal, Dialog and Popup Styles Refactor

Open josh-bagwell opened this issue 1 year ago • 1 comments

Summary

Fixes: #2773

Styles refactor for Modal, Dialog and Popup.

Release Category

Components

Release Note

Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.

BREAKING CHANGES

Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a prerelease/major branch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.


Checklist

  • [ ] MDX documentation adheres to Canvas Kit's Documentation Guidelines
  • [ ] Label ready for review has been added to PR

For the Reviewer

  • [ ] PR title is short and descriptive
  • [ ] PR summary describes the change (Fixes/Resolves linked correctly)
  • [ ] PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • [ ] Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • [ ] Code
  • [ ] Documentation
  • [ ] Testing
  • [ ] Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

josh-bagwell avatar Jun 27 '24 00:06 josh-bagwell

Passing run #7471 ↗︎

0 847 3 0 Flakiness 0

Details:

Merge 634af03a85fe40f5dd304db201df8f99c0aa5fb5 into 066c4b170850949586bf9f89370f...
Project: Workday/canvas-kit Commit: b71f09f73f ℹ️
Status: Passed Duration: 04:50 💡
Started: Jul 19, 2024 6:49 PM Ended: Jul 19, 2024 6:54 PM

Review all test suite changes for PR #2795 ↗︎

cypress[bot] avatar Jul 02 '24 19:07 cypress[bot]