feature-close: Include PR id

Open pmatzavin opened this issue 7 years ago • 3 comments

Automatically append the PR id in the commit msg when closing a feature branch.

May 30 '18 13:05 pmatzavin

This would match github's merge functionality. But would you really expect this from oneflow?

May 30 '18 13:05 nikostoulas

It is a nice to have as it automates the correlation of the master-commit to the Github PR request. But I can see that the scope of oneflow is not to act as a Github client, maybe it could have some optionally Github integration/functionality.

May 30 '18 15:05 pmatzavin

Oneflow could have a hook to do sth before merging. Eg: prompt the user to change the msg or run a bash command. Should this handle only squash commits? I think GitHub only does this for squash commits

May 31 '18 07:05 nikostoulas