wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Prevent emojis in plugin titles from appearing before text

Open Infinite-Null opened this issue 10 months ago • 2 comments

Trac ticket: #63120

What

When a plugin title contains an emoji (e.g., myplugin❤️wordpress), the emoji incorrectly appears before the text on the WordPress plugins admin page, showing as ❤️mypluginwordpress.

Screenshot:

Before Patch:

wp-admin/plugins.php:

image

After Patch:

wp-admin/plugins.php:

image

Plugin Update Page:

image

Infinite-Null avatar Mar 18 '25 17:03 Infinite-Null

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ankitkumarshah, ant1busted, sandeepdahiya.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Mar 18 '25 17:03 github-actions[bot]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Mar 18 '25 17:03 github-actions[bot]

Hi, I did try this PR in playground and it worked, but I tried with a classic playgournd (not including the PR) it also worked. Are you sure this does not come from something else in your install? image

ant1sg avatar May 18 '25 17:05 ant1sg

Hi @ant1sg, Thank you for testing the PR!

In your case, it seems that the system fonts are being used for rendering emojis. WordPress includes a fallback mechanism where, if the emoji feature detection test fails, emojis are loaded from https://s.w.org/images/core/emoji/15.0.3/svg/.

However, since your browser successfully uses system emojis, this fallback behavior isn’t triggered hence, the issue doesn’t occur on your end.

Infinite-Null avatar May 19 '25 05:05 Infinite-Null

Hello @Infinite-Null yes I just noticed all the comments on Trac, I had not seen them. Sorry about that. I'll try to rerun the test properly

ant1sg avatar May 19 '25 07:05 ant1sg

I tried and this patch submitted and it is working perfectly. Thanks.

iamsandeepdahiya avatar Jun 01 '25 14:06 iamsandeepdahiya

Closing as merged 60680

Infinite-Null avatar Sep 09 '25 15:09 Infinite-Null