Do not hardcode script languages path for themes

[swissspidy]

The change in https://core.trac.wordpress.org/ticket/60891 / https://core.trac.wordpress.org/changeset/57922 was not tested enough with themes that load script translations. It caused a regression where WP tried to look up script translations for a theme in wp-content/languages/plugins.

Even when using a custom WP_PLUGIN_DIR/WP_PLUGIN_URL configuration, we should always use the correct path for themes and plugins alike.

To-do:

• [ ] Add unit tests

Trac ticket: https://core.trac.wordpress.org/ticket/62016

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions[bot]]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props swissspidy.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions[bot]]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[swissspidy]

Committed in https://core.trac.wordpress.org/changeset/59126

[them-es]

@swissspidy Could you have a look at whether this is a viable alternative approach?

Replace the changes in this commit with only the following line: Line 1210 $languages_path = WP_LANG_DIR . '/' . $relative[0];

At least this fixes a regression reported 2 weeks ago: https://core.trac.wordpress.org/ticket/62155

[swissspidy]

No, this just reintroduces the original bug.

[swissspidy]

@them-es #7562 should address this, please test

[them-es]

@swissspidy Yes that seems to fix the reported Multisite regression. Thank you for the quick turnaround 👍