wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Add copy button when creating new application password Fix/62019

Open circlecube opened this issue 1 year ago • 6 comments

Trac ticket: https://core.trac.wordpress.org/ticket/62019

Updating the existing patch to capitalize the button text 'copy > 'Copy' and making the text translatable.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

circlecube avatar Sep 17 '24 21:09 circlecube

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props circlecube, jeremyfelt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Sep 17 '24 21:09 github-actions[bot]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Sep 17 '24 22:09 github-actions[bot]

Things are looking good so far, @circlecube, thanks!

A couple more notes:

  1. We should apply these changes to wp-admin/profile.php as well. I think folks are more likely to be adding application passwords through that screen rather than while editing another user.
  2. We can probably add a bit of spacing above "Copy" on mobile. (See screenshot)

CleanShot 2024-09-17 at 15 42 28@2x

jeremyfelt avatar Sep 17 '24 22:09 jeremyfelt

  1. We should apply these changes to wp-admin/profile.php as well. I think folks are more likely to be adding application passwords through that screen rather than while editing another user.

The wp-admin/profile.php file loads up wp-admin/user-edit/php i.e. these changes are on the profile page now.

  1. We can probably add a bit of spacing above "Copy" on mobile.

Good catch @jeremyfelt, looking at this now.

circlecube avatar Sep 17 '24 23:09 circlecube

The wp-admin/profile.php file loads up wp-admin/user-edit/php i.e. these changes are on the profile page now.

Ha! I swear this was not working, but there it is. My fault!

jeremyfelt avatar Sep 17 '24 23:09 jeremyfelt

Screenshots of the mobile layout with a tiny CSS tweak: application-secret-copy-mobile-small application-secret-copy-mobile

circlecube avatar Sep 18 '24 22:09 circlecube