wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Warn about empty templates in the frontend

Open vcanales opened this issue 1 year ago • 2 comments

Proposes adding a warning for logged-in users when navigating to a page or post rendered through an empty template. The warning explains why the website's visitors might encounter a blank page and points the logged-in user to the Site Editor to fix the template by resetting it or adding content to it.

Related issue: https://github.com/WordPress/gutenberg/issues/64027

Trac ticket:

Screenshot

image


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

vcanales avatar Sep 14 '24 15:09 vcanales

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props vcanales, mikachan, peterwilsoncc, richtabor, get_dave, mrfoxtalbot, matveb, arielmaidana, seifradwane, annezazu.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]

Thank you for working on this @vcanales, I added a comment with two minor suggestions https://github.com/WordPress/gutenberg/issues/64027#issuecomment-2385791997

mrfoxtalbot avatar Oct 01 '24 13:10 mrfoxtalbot

Can I ask you, @cbravobernal, or maybe @getdave to review this? I'd love for this change to make it to the 6.7 in time. Thanks a bunch.

mrfoxtalbot avatar Oct 01 '24 14:10 mrfoxtalbot

Thanks for all the feedback, @richtabor 🙇 I think I've addressed all your comments, this is ready for another review.

mikachan avatar Nov 13 '24 11:11 mikachan

@mikachan Let me know when you are ready to commit this and we can pair on commit to WP Core.

getdave avatar Nov 20 '24 11:11 getdave

@mikachan This now needs a commit. A good opportunity for you. LMK if you want to run through this.

getdave avatar Nov 22 '24 09:11 getdave

Committed to Core in core.trac.wordpress.org/changeset/59449.

mikachan avatar Nov 22 '24 11:11 mikachan