wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Fixed: #61785 Misalignment of Search Text Box and Keywords Dropdown on Add New Plugin Page

Open iflair opened this issue 1 year ago • 6 comments

We have tested it with the patch provided above... But it seems like this is not working with many devices. Therefore we have attached the patch file for the solution and made it work across all devices. Attached image: [https://tinyurl.com/28xxju56] Trac ticket URL : https://core.trac.wordpress.org/ticket/61785

iflair avatar Jul 31 '24 07:07 iflair

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

github-actions[bot] avatar Jul 31 '24 07:07 github-actions[bot]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @sagarbhatia-iflair.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iflairwebtechnologies, jomonthomaslobo1.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Jul 31 '24 07:07 github-actions[bot]

We have tested it with the patch provided above... But it seems like this is not working with many devices. Therefore we have attached the patch file for the solution and made it work across all devices. Attached image: [https://tinyurl.com/28xxju56] Trac ticket URL : https://core.trac.wordpress.org/ticket/61785

iflair avatar Jul 31 '24 07:07 iflair

@iflair @sagarbhatia-iflair Thanks for the updated fix

jomonthomaslobo avatar Jul 31 '24 07:07 jomonthomaslobo

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Jul 31 '24 07:07 github-actions[bot]

Screenshot from 2024-07-31 13-32-44 Works fine

jomonthomaslobo avatar Jul 31 '24 08:07 jomonthomaslobo

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 59706 GitHub commit: https://github.com/WordPress/wordpress-develop/commit/08a292b7f6f853bd081097204d8760c4c8a12637

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

github-actions[bot] avatar Jan 25 '25 14:01 github-actions[bot]