wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Refresh - Validate URL in Locate Template

Open shail-mehta opened this issue 1 year ago • 2 comments

Added refresh patch for Validate url in locate template.

Trac ticket: https://core.trac.wordpress.org/ticket/58905

shail-mehta avatar May 04 '24 06:05 shail-mehta

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, jorbin, mukesh27, martinkrcho, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 04 '24 06:05 github-actions[bot]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar May 04 '24 07:05 github-actions[bot]

@mukeshpanchal27 Are you able to edit the comment above to note the raw difference. As the benchmarking script is using hrtime() (nanoseconds) I think the raw numbers could be more helpful than a percentage.

peterwilsoncc avatar Sep 04 '24 03:09 peterwilsoncc

@peterwilsoncc Updated https://github.com/WordPress/wordpress-develop/pull/6502#pullrequestreview-2259763696

mukeshpanchal27 avatar Sep 04 '24 04:09 mukeshpanchal27

Converting the raw times from nanoseconds to milliseconds is showing a showdown of between 0.7ms to 2.5ms over 1000 iterations so I don't think it's worth considering the performance impacts as a reason to block the benefits of avoiding using the function to include files outside of the template paths.

peterwilsoncc avatar Sep 04 '24 23:09 peterwilsoncc