wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Add a `label` field in the search controller to return localized type for each item

Open petitphp opened this issue 2 years ago • 3 comments

This change is related to a PR in gutenberg to display localize name for suggestions in the link component.

This change felt too complex to be added to the gutenberg repository and backported afterward. Also I wanted to be able to update existing tests for the REST search handler.

This PR contain two changes :

  • Add a new label property in the WP_REST_Search_Controller and update existing handlers to fill this property accordingly
  • Add a new WP_REST_Media_Search_Handler handler to uniformize the shape of the data send back by the search endpoint between all types.

Trac ticket: https://core.trac.wordpress.org/ticket/61254

petitphp avatar Feb 14 '24 21:02 petitphp

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Feb 14 '24 21:02 github-actions[bot]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props petitphp, timothyblynjacobs.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 20 '24 13:05 github-actions[bot]

It looks like the associated Gutenberg PR hasn't been merged yet. I'm leaving feedback there for now.

TimothyBJacobs avatar May 20 '24 16:05 TimothyBJacobs