plugin-check icon indicating copy to clipboard operation
plugin-check copied to clipboard

Add initial code owners configuration

Open swissspidy opened this issue 1 year ago • 2 comments

Moving checks into separate folders per category makes it easy to set up code owners.

Feel free to submit suggestions to the CODEOWNERS file if you like to be included/excluded.

See #448

swissspidy avatar Apr 29 '24 14:04 swissspidy

We can create new teams for each category or something if we want, e.g. @WordPress/plugin-check-plugins-team, @WordPress/plugin-check-performance. Don't want to use that existing team though, as it includes too many people who aren't contributing this plugin and would just unnecessarily get pinged because of it (like right now :)).

(Edit: also keep in mind mentioning/assigning teams doesn't work for people not in the org or when logged out of GitHub)

Not worried about back compat, a changelog entry should be enough.

swissspidy avatar Apr 29 '24 15:04 swissspidy

Who is responsible for the other checks and other infrastructure-related files?

Everyone and no one :) Something we can define as we go. Suggestions welcome if you think we should define all of that already.

swissspidy avatar Apr 30 '24 06:04 swissspidy

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: swissspidy <[email protected]>
Co-authored-by: joemcgill <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Jul 03 '24 12:07 github-actions[bot]

Looks great and this will let individual teams iterate more rapidly. +1.

adamsilverstein avatar Jul 09 '24 16:07 adamsilverstein

@bordoni @chriscct7 @davidperezgar @barrykooij Would appreciate eyes on this from the plugins team as well as it means you'll get notified more often for PRs (every time some touches checks related to your team).

IMHO adding a code owners configuration is a great way to more clearly separate concerns. Even if we end up restructuring the plugin further down the road, this would be a good thing to do.

swissspidy avatar Jul 10 '24 11:07 swissspidy

I wait @barrykooij have an opinion of this.

But it looks great as we have very clear information where to see the checks.

davidperezgar avatar Jul 10 '24 11:07 davidperezgar