phpunit-test-reporter icon indicating copy to clipboard operation
phpunit-test-reporter copied to clipboard
verified publisher icon WordPress

Check PHP8 compatibility

Open pfefferle opened this issue 5 years ago • 6 comments

https://wordpress.slack.com/archives/C3D6T7F8Q/p1593596189094100

pfefferle avatar Jul 01 '20 09:07 pfefferle

Doing this step by step.

Step one:

  • I tested the plugin in PHP8 and it seems to work as expected so far.

Next:

  • Get reporter's automated tests running with PHP8
  • Check to see that test runner works as expected with PHP8: https://github.com/WordPress/phpunit-test-runner/issues/121

getsource avatar Oct 26 '20 07:10 getsource

Potentially related: https://twitter.com/ottokekalainen/status/1322275628662595585?s=21

First 👏 and thanks to Seravo for adding PHP8 testing. ❤️

I'm am trying to figure out why the tests fail for them but not Core on Travis, and wondering if something in here is causing the failure.

desrosj avatar Oct 30 '20 20:10 desrosj

If it helps debugging, here is the same commit tested with both PHP 7.4 (pass) and PHP 8.0 (failure):

https://make.wordpress.org/hosting/test-results/r49470/seravobot-r49470/

image

image

The PHP 8.0 was the latter run, so it's results remain on the result page.

Since the result page does not show any detailed log, I have attached them manually. php80.txt php74.txt

ottok avatar Nov 01 '20 20:11 ottok

There might be more problems, but I think the main issue is that the test runner is using PHPUnit 5.6.x: https://github.com/WordPress/phpunit-test-runner/issues/121#issuecomment-717169367

getsource avatar Nov 03 '20 10:11 getsource

If somebody makes a PR or test branch on this topic, I am happy to run the test runner based on code from an alternative branch to verify if the proposed changes fix the issue.

ottok avatar Nov 05 '20 07:11 ottok