gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Apply `exhuastive-deps` lint rule if possible to native files of `components` package

Open fluiddot opened this issue 3 years ago • 1 comments

What problem does this address?

Once this PR is merged, the exhuastive-deps lint rule will be ignored in some of the components under the components package. This is not ideal as for some of them it would be possible to pass the lint rule.

What is your proposed solution?

It would be great if we could review each change made in this PR. The idea is that we decide for each case whether is possible to pass the exhuastive-deps lint rule:

  • If it's doable, let's apply the needed refactor.
  • If not, update the code's comment explaining why it's not doable.

fluiddot avatar Sep 16 '22 10:09 fluiddot

@fluiddot just wanted to update y'all, I came a cross a few more of these while working on some other components. We're nearing the end of the list, so I don't anticipate a ton more, but I'll continue linking related issues here if any more come up 🙂

chad1008 avatar Sep 22 '22 16:09 chad1008

@fluiddot just wanted to update y'all, I came a cross a few more of these while working on some other components. We're nearing the end of the list, so I don't anticipate a ton more, but I'll continue linking related issues here if any more come up 🙂

Great, thank you very much @chad1008 for letting us know, we'll keep an eye on this 🙇 .

fluiddot avatar Sep 23 '22 12:09 fluiddot