create-block-theme icon indicating copy to clipboard operation
create-block-theme copied to clipboard

Tag Full Site Editing is missing

Open kafleg opened this issue 2 years ago • 3 comments

While checking Appearance > Create Block Theme, there is no option to select Full Site Editing tag. Without that tag, themes trac will not be recognized as Full Site Editing(Block Theme).

I checked the function get_theme_feature_list() and found, Replaced 'Full Site Editing' feature name with 'Site Editor'.

But, I guess those tags should be aligned with the list of tags that we have in the Theme Check plugin and tags in the themes repository.

Also, we don't allow custom tags in the theme for the WordPress themes repository, I don't think it is necessary to give the option to add custom tags.

P.S. I assume that the generated themes will be submitted in the org themes repository.

kafleg avatar Apr 12 '23 03:04 kafleg

I checked the function get_theme_feature_list() and found, Replaced 'Full Site Editing' feature name with 'Site Editor'.

The theme is exported with the full-site-editing tag when Site Editor is checked. This seems like something to correct in the get_theme_feature_list function, if we wanted those to be consistent?

Also, we don't allow custom tags in the theme for the WordPress themes repository, I don't think it is necessary to give the option to add custom tags.

Hmm, I think there may be use cases for adding a custom tag here. I think it's okay to leave the custom tags field in, but I don't have a strong opinion. Maybe we can add a note above the form field suggesting that custom tags are not allowed in the .org repo.

jffng avatar Apr 25 '23 17:04 jffng

P.S. I assume that the generated themes will be submitted in the org themes repository.

I don't think that is the case for the majority of the themes. People just want to make changes and have their own theme that way.

carolinan avatar Apr 26 '23 03:04 carolinan

As a themes team rep, I think it is best to assume. haha

kafleg avatar Apr 26 '23 03:04 kafleg