CustomCrafting icon indicating copy to clipboard operation
CustomCrafting copied to clipboard

Recipes in the smithing table eventually get lost after restarting the server or just like that

Open MrJorman opened this issue 3 years ago • 28 comments

What happened?

recipes by themselves get lost and are not crafted in a blacksmith's table.

image

MyConfig:

{
  "@type" : "customcrafting:smithing",
  "group" : "",
  "hidden" : false,
  "vanillaBook" : true,
  "priority" : "NORMAL",
  "checkNBT" : false,
  "conditions" : {
    "values" : [ ]
  },
  "base" : {
    "items" : [ {
      "custom_amount" : 1,
      "item" : {
        "==" : "org.bukkit.inventory.ItemStack",
        "v" : 2975,
        "type" : "DIAMOND_HELMET",
        "meta" : {
          "==" : "ItemMeta",
          "meta-type" : "UNSPECIFIC",
          "lore" : [ ]
        }
      }
    } ],
    "tags" : [ ],
    "replaceWithRemains" : true,
    "allowEmpty" : false
  },
  "addition" : {
    "items" : [ {
      "custom_amount" : 1,
      "itemsadder" : "blessedcraft:necromium_ingot"
    } ],
    "tags" : [ ],
    "replaceWithRemains" : true,
    "allowEmpty" : false
  },
  "preserveEnchants" : true,
  "preserveDamage" : true,
  "onlyChangeMaterial" : false,
  "result" : {
    "items" : [ {
      "custom_amount" : 1,
      "eco" : "ecoarmor:set_necromium_helmet"
    } ],
    "tags" : [ ],
    "extensions" : [ ]
  }
}

How can the bug be reproduced?

Create 10 recipes from ItemsAdder or EcoArmors. damage or enchant the armor and try to craft your custom armor from it, some elements will not be crafted, I don't know what this is related to.

Expected Behaviour?

damage or enchant the armor and try to craft your custom armor from it, some elements will not be crafted, I don't know what this is related to.

Plugin version

CustomCrafting 3.16.3.1, WolfyUtilites 3.16.3.2

Server software

Purpur 1.18.2

Relevant log output

f

Submit issue

  • [X] read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • [X] searched for and ensured there isn't already an open issue regarding this,
  • [X] are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

MrJorman avatar Mar 11 '22 03:03 MrJorman

smithing.zip

My Configs, maybe you check.

MrJorman avatar Mar 11 '22 03:03 MrJorman

HM, Video testing: https://youtu.be/_37sknWv-y0

MrJorman avatar Mar 11 '22 04:03 MrJorman

FIX please.

MrJorman avatar Mar 11 '22 19:03 MrJorman

For some reason, your helmet in the recipe requires an empty lore. So it only works with the exact NBT.

I suspect that it happens when you equip the item or something. To help me find the cause, please do the following:

  1. Get a new helmet from the creative menu
  2. Hold the helmet in your hand.
  3. Run /data get entity @s SelectedItem
  4. Equip the helmet
  5. Take it back into your hand and run /data get entity @s SelectedItem again.

The output of the commands is the part I need.

WolfyScript avatar Mar 11 '22 20:03 WolfyScript

hold helmet in creative image

MrJorman avatar Mar 12 '22 08:03 MrJorman

equip helmet in head.

image

MrJorman avatar Mar 12 '22 08:03 MrJorman

Interesting. The item gets an empty lore when you equip it.... Are you able to try it again without CustomCrafting and WolfyUtilities installed? To make sure it isn't any of my plugins that cause this.

WolfyScript avatar Mar 12 '22 08:03 WolfyScript

sec

MrJorman avatar Mar 12 '22 08:03 MrJorman

image in creative no equip, i delete CustomCrafting and WolfyUtilites

MrJorman avatar Mar 12 '22 09:03 MrJorman

image equip helmet in head

MrJorman avatar Mar 12 '22 09:03 MrJorman

i test, plugin Eco add Lore.

MrJorman avatar Mar 12 '22 09:03 MrJorman

yes, the problem is Eco plugin the changes there.

MrJorman avatar Mar 12 '22 09:03 MrJorman

for some reason, the strength of the object and the charms are not transferred.

MrJorman avatar Mar 12 '22 09:03 MrJorman

Ok. To fix your recipes now, make to only use the items directly out of the creative menu! You would also have to update all of those recipes that contain the invalid items.

WolfyScript avatar Mar 12 '22 09:03 WolfyScript

I have updated the eco plugin and the error was corrected, but there was an error with the transfer of enchantments and durability.

MrJorman avatar Mar 12 '22 09:03 MrJorman

Preserve Enchants and Preserve Damage no working.

MrJorman avatar Mar 12 '22 09:03 MrJorman

image

MrJorman avatar Mar 12 '22 09:03 MrJorman

image Strangely, when I put the item on, a new line still appears

MrJorman avatar Mar 12 '22 09:03 MrJorman

image taking the diamond chestplate from the creative and enchanting it, preserve enchants doesn't work anyway image

MrJorman avatar Mar 12 '22 09:03 MrJorman

image hmm, now I have replaced the ID of the item from the creative without Lore: [] and working. pls fix bug.

MrJorman avatar Mar 12 '22 09:03 MrJorman

I found a bug if the Eco plugin is installed and take a clean item/armor from the creative - it will not have nbttag: lore [], but if you put it on yourself or move it around the inventory and chests, then it adds nbttag: lore[] to itself and after that custom crafting does not work correctly.

MrJorman avatar Mar 12 '22 09:03 MrJorman

but it is strange that some items have this {lore: []} and they are still being crafted, and some are not being created.

MrJorman avatar Mar 12 '22 09:03 MrJorman

sec, i fix. i delete config file Eco.

MrJorman avatar Mar 12 '22 09:03 MrJorman

The lore issue is an eco issue then.

The recipe is working as expected, because it triggers the NBT check, so only items with that empty lore are accepted.

WolfyScript avatar Mar 12 '22 09:03 WolfyScript

hm, no fixed.

MrJorman avatar Mar 12 '22 09:03 MrJorman

I have recreated the eco config, and {lore: []} is still being created. Help me fix it.

MrJorman avatar Mar 12 '22 09:03 MrJorman

I have recreated the eco config, and {lore: []} is still being created. Help me fix it.

As I said take the items directly from the creative menu into the GUI! That will fix the recipe!

Stop begging for the issue to be fixed. I am tired of all of your messages with "Please fix", "fix this", "fix it", etc. Those messages are annoying and don't help in the slightest.

  • They are annoying
  • They don't speed up process of your issue (in fact, it has the opposite effect)
  • They don't add any helpful information to the issues.
  • You are not the only one that requires support and I need to manage a lot of other issues.
  • I have a life outside of the internet, I look into issues when I have time. (At the moment I also have to study for Uni)

And when it comes to the eco issue... at least create a good bug report, in the eco repository, explaining the issue in detail. And remember that the lore issue is unrelated to CC and WU, so the title is already wrong.

WolfyScript avatar Mar 12 '22 10:03 WolfyScript

As I said take the items directly from the creative menu into the GUI! That will fix the recipe!

no working. some items players have when they craft them already have nbttag: {lore: []}

MrJorman avatar Mar 12 '22 13:03 MrJorman