WohlSoft
Reserve item fix
Pretty self explanatory, dropped reserve items no longer have their height hardcoded to 32, it is instead set to the height NPC config field.
I'd personally want to see some way to disable this (though that'd depend a bit on the mission of X2 which the community will hopefully think through in the coming weeks).
Unlikely. If the new X2 team wants TheXTech to be used as the reference implementation of the SMBX 1.3 standard (I wouldn't complain!) then no disable mechanism would be needed.
But as far as I'm aware, people do currently use X2 to do things like TAS SMBX 1.3 episodes, or to research SMBX 1.3 logic. This bugfix would make that a bit harder.
A bit late to the conversation (apologies for that), but at least in my opinion it's definitely worth having a Misc.SetReserveItemHeightFix(bool) function. I can think of two episodes that put larger NPCs in the player's reserve box (MaGLX3 and Bestified), though I don't remember if the height crunch mattered for gameplay in either case. Nonetheless, I do agree with allowing to disable it for speedrun and research purposes as ds mentioned, as well as any users who might want a deliberate glitch/jank aesthetic in their levels/episodes.
From a cursory look at ffi_misc.lua, it seems like most of the Misc functions for 1.3 bug fixes are wrappers for LunaLuaSet_Fix(bool) functions? So if it's not too much trouble, please do expose this fix in the same way as the others have been.
Ahh, you meant merge here, right. I was thinking the main X2 repo over on Gitlab. I don't have the perms to merge on this repo, but yeah, the test build you gave me seems to work.
So whoever can merge this PR, they've got my go-ahead to do so.