wgcfg: new package

Open crawshaw opened this issue 5 years ago • 2 comments

Mar 30 '20 22:03 crawshaw

@danderson this is I think entirely self-contained so shouldn't need much review.

Mar 30 '20 22:03 crawshaw

@danderson this is I think entirely self-contained so shouldn't need much review.

Config semantics are important and this code seems pretty half-baked (there's a "TODO: this is broken, remove me" still in there). Reopening this.

Maintaining a code base does not mean committing stuff in a "throw it over the fence" manner. It means having a real attention to detail and care, which takes focus before committing.

I didn't want to have to comment on any of this and let you handle everything, but the quality here is questionable.

Please fix this stuff up.

Apr 05 '20 03:04 zx2c4