eyesome icon indicating copy to clipboard operation
eyesome copied to clipboard

Sunset time not being processed correctly

Open mattharbord opened this issue 4 years ago • 4 comments

The times pulled showed additional html in the Sunrise setting and Sunset Setting in eyesome setup > Sun Times - while the sunrise time was being pulled correctly, the sunset hour was consistently being set to 12

I made the following change to eyesome-sun.sh which seemed to fix it, but didn't want to open a PR as I'm just hacking around and my change probably broke something / wasn't needed (though it seems to work for me...)

### "-q"= quiet, "-O-" pipe output
    wget -q -O- "$SunHoursAddress" \
        | grep -oE 'Sunrise Today.{35}' | awk -F\> '{print $3}' | \
        awk -F\< '{print $1}' > /tmp/eyesome-sunrise
    wget -q -O- "$SunHoursAddress" \
        | grep -oE 'Sunset Today.{35}' | awk -F\> '{print $3}' | \
        awk -F\< '{print $1}' > /tmp/eyesome-sunset

mattharbord avatar Oct 01 '21 14:10 mattharbord

@mattharbord It would help to know the website address you used to get sunrise/sunset times. Also a picture of what your screen looks like after address is keyed into browser bar.

WinEunuuchs2Unix avatar Oct 03 '21 21:10 WinEunuuchs2Unix

@mattharbord Another user posted issue with 24 hour clock and eyesome-sun.sh was updated yesterday to address the problem. Please review and let me know if it works for you. Thanks.

WinEunuuchs2Unix avatar Oct 15 '21 10:10 WinEunuuchs2Unix

The bug still seems to be here. The script is reading the 07:21 in the sunset time as AM instead of PM. And I can't seem to override the sunrise and sunset times no matter what I try.

vinivosh avatar Mar 23 '22 13:03 vinivosh

@vinivosh Can we confirm your Sun Times window looks something like this:

image

The "am" is forced in the morning and "pm" is forced at night.

You can only enter 1-12 for the hours.

A screen shot from your machine might help figure out the problem.

Thanks,

pippim avatar Mar 27 '22 16:03 pippim