difftastic

difftastic copied to clipboard

closes #253 thanks to @petrochenkov's fix mentioned there. I just switched the order of a few lines. I did not change any in the build.rs. The rust-toolchain.toml had to be...

fdncred

The bold/normal text styling is harder to spot in larger comments.

Wilfred

Visible when viewing this commit: https://github.com/slackhq/vscode-hack/commit/da61b6c502587eebd3df9880c86467efc3cf0606

Wilfred

Using inside magit

6

This is completely off-topic but I'm not sure where to discuss this. You seem to be a magit user and I was wondering if you were using difftastic with magit?...

DamienCassou

Use interior mutability to represent graph predecessors

1

See the mutable_vertices branch. This might save perf, as we're currently spending most of our time looking up items in hashmaps. It's also worth exploring whether a conventional eager graph...

Wilfred

Model parent nodes accurately

7

See the [accurate_ancestors_with_fallback](https://github.com/Wilfred/difftastic/compare/accurate_ancestors_with_fallback) branch.

Wilfred

Explore 'shared unique' heuristics

1

Try never recursing into a shared unique node. Shared uniqueness is probably a useful property to store in metadata too.

Wilfred

Improve detection of extracted symbols

1

Hey, consider this example: I think a more "valid" diff would be to show that `gui.render` has been wrapped by `helpers.OnScrollFunc` and that the next line is new. Rendered diff...

artuross

Rust attribute changes are not ideally associated

3

Using the [indexmap](https://github.com/bluss/indexmap) repo, I tried the following command: GIT_EXTERNAL_DIFF=difftastic git show --ext-diff 49d430808ced6d1824ec15d621acd6b0e8367c19 and got this output near the end:  Notice how the `#[test]` attribute is interpreted, where...

cuviper

Explore narrowing unchanged singleton lists

1

This would help reduce the maximum nesting that we encounter.

Wilfred