Wildbook icon indicating copy to clipboard operation
Wildbook copied to clipboard

display bulk import file name as uploaded

Open TanyaStere42 opened this issue 1 year ago • 6 comments

Context Wildbook currently does filename processing to remove characters from bulk import file names

To allow for easy reconciliation between files in system and external to the system, we need to display the filename as it was originally uploaded, regardless of what preprocessing we do. This means that the original filename should be stored as a string and used for display. (update to parameters json for ImportTask)

Current Behavior file Caitlin_December_final.xlsx displays as CaitlinDecemberfinal.xlsx

Expected Behavior file Caitlin_December_final.xlsx displays as Caitlin_December_final.xlsx

Acceptance Criteria Display is updated on the following pages to show the original file name:

  • /src/main/java/org/ecocean/servlet/importer/StandardImport.java
  • /src/main/webapp/imports.jsp
  • /src/main/webapp/import.jsp

Notes Related to https://github.com/WildMeOrg/Wildbook/issues/267

Community link https://community.wildme.org/t/underscores-dashes-no-longer-displaying-or-exporting-correctly/2721

TanyaStere42 avatar Feb 16 '24 20:02 TanyaStere42

Community link: https://community.wildme.org/t/underscores-dashes-no-longer-displaying-or-exporting-correctly/2721

TanyaStere42 avatar Feb 16 '24 20:02 TanyaStere42

I'd just like to clarify that we also need the original image file name to display accurately on the match results page where it is currently displayed over top of the annotated target image and the annotated match candidate(s). Same criteria as above for exports: Current Behavior file Caitlin_December_final.xlsx currently displays as CaitlinDecemberfinal.xlsx

Expected Behavior file Caitlin_December_final.xlsx currently displays as Caitlin_December_final.xlsx

Per this post on the Community forum: https://community.wildme.org/t/underscores-dashes-no-longer-displaying-or-exporting-correctly/2721?u=acwadmin1

T4Cmaureen avatar Feb 16 '24 22:02 T4Cmaureen

Excellent! Thank you for catching that, I'll get the requirement updated to include that

TanyaStere42 avatar Feb 16 '24 22:02 TanyaStere42

@TanyaStere42 I would like to give a try could you please assign it to me

shamonhashmi148 avatar Feb 16 '24 23:02 shamonhashmi148

Absolutely! If you find you need help with system setup or anything, checkout the discord (although we are heading into a long weekend)

TanyaStere42 avatar Feb 17 '24 00:02 TanyaStere42

Hi all, any update on this issue? this remains a significant problem in that it doesn't allow users to reconcile their original datasets (pre-upload) with their exported data. Also causes issues deciphering the file names on match results where users intentionally insert location information to assist with confirmation, or not, of difficult match candidates. It was raised originally by an ACW user back in Aug and again in Nov '23. Hoping to see resolution of this soon. thanks

T4Cmaureen avatar Mar 13 '24 18:03 T4Cmaureen

@TanyaStere42 I'm going to take a look at this issue, could you assign it to me please?

Rodhlann avatar Nov 21 '24 07:11 Rodhlann

Just so I understand, is the intent here to save the original filename instead of the processed filename? Or are we wanting to add an additional field for storing the original filename?

If the latter, why is it important to process the filename so that we are storing a different value than the original name?

Rodhlann avatar Nov 21 '24 07:11 Rodhlann

I believe there were technical concerns around support for encoded characters, which caused the pre-processing to take place. @naknomum to confirm

At this point, the pre-processed version of the bulk import is used across the product, and rather than risk introduction of a regression somewhere, we just wanted to do the quick-and-easy of storing and displaying the original filename, but keeping the modified version throughout the pipeline

TanyaStere42 avatar Nov 21 '24 16:11 TanyaStere42

i forget the backstory, but i do think we squash certain things (underscores is one) during the file upload. looking around, i am noticing that in reviewDirectory.jsp (which happens post-file-upload, but displays filenames) we use a rather tricky reference to the original filenames via some session storage! oh boy. so i suspect this is the data we might need to employ or this fix to reported missing files.

naknomum avatar Nov 22 '24 00:11 naknomum

Some backstory on "why do we need to store the original filename somewhere else": users export data and like to cross-reference their data in Wildbook against their own internal data management systems. For some orgs, cross-referencing against the original filename is the easiest way to get data alignment between Wildbook and their system.

JasonWildMe avatar Nov 22 '24 02:11 JasonWildMe